Merge pull request #1 from badgeteam/tnt/fpga

Reset & CS of LCD open drain in when disabled
Nicolai-Electronics · May 16, 2022 · 3a8fe48 · 3a8fe48
2 parents 4bc9099 + 8fe7ca9
commit 3a8fe48
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/ili9341.c b/ili9341.c
@@ -165,8 +165,10 @@ esp_err_t ili9341_reset(ILI9341* device) {
         ESP_LOGI(TAG, "reset");
         esp_err_t res = gpio_set_level(device->pin_reset, false);
         if (res != ESP_OK) return res;
+        res = gpio_set_direction(device->pin_reset, GPIO_MODE_OUTPUT);
+        if (res != ESP_OK) return res;
         vTaskDelay(50 / portTICK_PERIOD_MS);
-        res = gpio_set_level(device->pin_reset, true);
+        res = gpio_set_direction(device->pin_reset, GPIO_MODE_INPUT);
         if (res != ESP_OK) return res;
         vTaskDelay(50 / portTICK_PERIOD_MS);
     } else {
@@ -269,12 +271,6 @@ esp_err_t ili9341_init(ILI9341* device) {
     }*/
 
     if (device->mutex != NULL) xSemaphoreGive(device->mutex);
-
-    //Initialize reset GPIO pin
-    if (device->pin_reset >= 0) {
-        res = gpio_set_direction(device->pin_reset, GPIO_MODE_OUTPUT);
-        if (res != ESP_OK) return res;
-    }
 
     //Initialize data/clock select GPIO pin
     res = gpio_set_direction(device->pin_dcx, GPIO_MODE_OUTPUT);
@@ -338,17 +334,13 @@ esp_err_t ili9341_deinit(ILI9341* device) {
     }
     res = gpio_set_direction(device->pin_dcx, GPIO_MODE_INPUT);
     if (res != ESP_OK) return res;
-    res = gpio_set_direction(device->pin_cs, GPIO_MODE_OUTPUT);
-    if (res != ESP_OK) return res;
-    res = ili9341_select(device, false);
+    res = gpio_set_direction(device->pin_cs, GPIO_MODE_INPUT);
     if (res != ESP_OK) return res;
     if (device->callback != NULL) {
         device->callback(true);
     }
     res = ili9341_reset(device);
     if (res != ESP_OK) return res;
-    res = ili9341_select(device, true);
-    if (res != ESP_OK) return res;
     return res;
 }