Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Destroy now calls plugin reset. Destroy also properly deallocates resour... #125

Closed
wants to merge 4 commits into from

Conversation

Scottmitch
Copy link

...ces if destroyed while editing

Address issue #124

@Scottmitch
Copy link
Author

The test case has been updated to demonstrate these modifications.

@Scottmitch
Copy link
Author

Test case updated to reflect last commit's changes.

…Corrected 'this' to 'self' where applicable.
@Scottmitch
Copy link
Author

Test case updated. Plugins now have destroy() hook. reset() is still called by destroy if jeditable is active to clean up controls.

@Scottmitch
Copy link
Author

@tuupola - Any updates on this being merged into the release?

NicolasCARPi added a commit that referenced this pull request Feb 15, 2018
@NicolasCARPi
Copy link
Owner

Hello,

Thank you for this very nice contribution. Your code has been merged! :)

Cheers,
~Nico

@Scottmitch Scottmitch deleted the issue_124 branch February 15, 2018 01:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants