This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
Added support for size and maxlength. #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just had to add this into my current project - it would be quite nice if it was packaged as part of the jeditable library by default! |
|
Why isn't this merged already?! |
|
+1 .. is this still being maintained? |
|
@hannesgassert exactly. Are these issues still being monitored? |
|
Some news about merging? |
|
@tuupola , pls give any feedback about this PR |
|
Hello, I'm the new maintainer for this repo. I'll merge this. Thanks for your contribution :) |
|
Merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for setting size and maxlength on a textfield. Would you like to pull this change into your repo?
André