Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

new feature to allow CSS style on buttons #71

Closed
wants to merge 3 commits into from

Conversation

quocvu
Copy link

@quocvu quocvu commented Sep 22, 2012

Hi Mika,
I added a few options to allow me to further style the form produced my jeditable.

  1. assign a id attribute to the form
  2. assign a class attribute to the submit and cancel button

In my case I use bootstrap css and we usually do things like <button class="btn btn-success" ...> thus I added the following for convenience

Hope you find it useful for other and merge it to your code

@tuupola
Copy link
Collaborator

tuupola commented Sep 22, 2012

I think you can already style buttons with CSS selector like form.editable > button. Is adding two new parameters to Jeditable really needed?

@quocvu
Copy link
Author

quocvu commented Sep 23, 2012

Hi Mika,

There are 2 use cases for what I did.

  1. if I can style buttons myself, I would have done form.editable > button, but since I use bootstrap which already styled the button I need to assign the bootstrap css class to the button
  2. If wanted to show the submit button in green and the cancel button in red, thus I needed something to differentiate them.

Thanks
Quoc


From: Mika Tuupola notifications@github.com
To: tuupola/jquery_jeditable jquery_jeditable@noreply.github.com
Cc: quocvu quoc_vu@yahoo.com
Sent: Saturday, September 22, 2012 7:42 AM
Subject: Re: [jquery_jeditable] new feature to allow CSS style on buttons (#71)

I think you can already style buttons with CSS selector like form.editable > button. Is adding two new parameters to Jeditable really needed?

Reply to this email directly or view it on GitHub.

@scotartt
Copy link

scotartt commented Mar 8, 2014

Hi I am going to comment on this issue because it is exactly the same issue (and only one of two issues) that I'm having with jquery_jeditable. Of course, I could style the buttons directly. But that's a chunk of css that's cut and pasted from bootstrap into my theme's customised css (so when I want to change my theme I have to edit it in two places now). Surely it's just easier to be able to assign the class I want to the button?

NicolasCARPi added a commit that referenced this pull request Feb 14, 2018
add the submitcssclass, cancelcssclass and formid options
@NicolasCARPi
Copy link
Owner

Hello,

This code has been merged and a demo example has been added to the demo page. Thanks for your contribution! :D

Cheers,
~Nico

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants