Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework #2 + improvements #7

Merged
merged 9 commits into from
Jun 21, 2018
Merged

Rework #2 + improvements #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6cdbfa1
Gets the provider class out to create an master extension.
Jun 21, 2018
43eb99f
Removes single quotes in comments
Jun 21, 2018
ba5b04b
Fixes the conditional tag
Jun 21, 2018
7cd1dca
Prepares responsive embedding
Jun 21, 2018
88ef5aa
Gets providers by checking class namespaces
Jun 21, 2018
1e29edb
Registers provider dedicated tags
Jun 21, 2018
29bd45d
Fixes providers 'Options' links
Jun 21, 2018
a78c5c1
Displays provider preferences by default
Jun 21, 2018
294c697
Removes the plugin name in the related preferences group name
Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 29 additions & 13 deletions src/Admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,17 @@ public function __construct()
null,
1
);

foreach (self::getProviders() as $provider) {
add_privs('plugin_prefs.' . $plugin . '_' . $provider, self::getPrivs());

register_callback(
'Oui\Player\Admin::optionsLink',
'plugin_prefs.' . $plugin . '_' . $provider,
null,
1
);
}
}

/**
Expand All @@ -83,7 +94,20 @@ public function __construct()

public static function setProviders()
{
static::$providers = callback_event(self::getPlugin(), 'plug_providers', 0, array());
$providers = array();

$namespace = __NAMESPACE__ . "\\";

foreach(get_declared_classes() as $name) {
if(strpos($name, $namespace) === 0) {
$providers[] = strtolower(substr($name, strlen($namespace)));
}
}

static::$providers = array_merge(array_diff(
$providers,
array('admin', 'player', 'main', 'provider')
));
}

public function install()
Expand All @@ -107,7 +131,9 @@ public function uninstall()

public static function optionsLink()
{
header('Location: ?event=prefs#prefs_group_' . self::getPlugin());
global $event;

header('Location: ?event=' . str_replace('plugin_prefs.', 'prefs#prefs_group_', $event));
}

/**
Expand Down Expand Up @@ -255,7 +281,7 @@ public static function setAllPrefs()

// Adds a pref per provider to display/hide its own prefs group.
$options = array(
'default' => '0',
'default' => '1',
'valid' => array('0', '1'),
);
$options['group'] = $plugin;
Expand Down Expand Up @@ -356,15 +382,5 @@ private function deleteOldPrefs()

if (txpinterface === 'admin' && (in_array($event, array('plugin', 'prefs')) || substr($event, 0, strlen($pluginPrefs)) === $pluginPrefs)) {
new Admin;

$providers = Admin::getProviders();

if ($providers) {
foreach ($providers as $provider) {
if (in_array($event, array($pluginPrefs . '_' . lcfirst($provider), 'prefs'))) {
$provider::getInstance();
}
}
}
}
}
7 changes: 7 additions & 0 deletions src/Player.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ class Player
'wraptag' => array(
'default' => '',
),
'responsive' => array(
'default' => '',
),
),
'oui_if_player' => array(
'play' => array(
Expand Down Expand Up @@ -107,6 +110,10 @@ class Player
'provider' => array(
'default' => '',
),
'responsive' => array(
'default' => 'true',
'valid' => array('true', 'false'),
),
'providers' => array(
'default' => '',
),
Expand Down