Skip to content

Commit

Permalink
fix typos unkown -> unknown
Browse files Browse the repository at this point in the history
  • Loading branch information
NicolasHug committed Jan 17, 2020
1 parent ef3ed6e commit 59e6886
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def fit(self, trainset):
def estimate(self, u, i):

if not (self.trainset.knows_user(u) and self.trainset.knows_item(i)):
raise PredictionImpossible('User and/or item is unkown.')
raise PredictionImpossible('User and/or item is unknown.')

# Compute similarities between u and v, where v describes all other
# users that have also rated item i.
Expand Down
3 changes: 2 additions & 1 deletion surprise/prediction_algorithms/algo_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ def predict(self, uid, iid, r_ui=None, clip=True, verbose=False):
The ``predict`` method converts raw ids to inner ids and then calls the
``estimate`` method which is defined in every derived class. If the
prediction is impossible (e.g. because the user and/or the item is
unkown), the prediction is set according to :meth:`default_prediction()
unknown), the prediction is set according to
:meth:`default_prediction()
<surprise.prediction_algorithms.algo_base.AlgoBase.default_prediction>`.
Args:
Expand Down
6 changes: 3 additions & 3 deletions surprise/prediction_algorithms/knns.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def fit(self, trainset):
def estimate(self, u, i):

if not (self.trainset.knows_user(u) and self.trainset.knows_item(i)):
raise PredictionImpossible('User and/or item is unkown.')
raise PredictionImpossible('User and/or item is unknown.')

x, y = self.switch(u, i)

Expand Down Expand Up @@ -186,7 +186,7 @@ def fit(self, trainset):
def estimate(self, u, i):

if not (self.trainset.knows_user(u) and self.trainset.knows_item(i)):
raise PredictionImpossible('User and/or item is unkown.')
raise PredictionImpossible('User and/or item is unknown.')

x, y = self.switch(u, i)

Expand Down Expand Up @@ -387,7 +387,7 @@ def fit(self, trainset):
def estimate(self, u, i):

if not (self.trainset.knows_user(u) and self.trainset.knows_item(i)):
raise PredictionImpossible('User and/or item is unkown.')
raise PredictionImpossible('User and/or item is unknown.')

x, y = self.switch(u, i)

Expand Down
4 changes: 2 additions & 2 deletions surprise/prediction_algorithms/matrix_factorization.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ class SVD(AlgoBase):
if known_user and known_item:
est = np.dot(self.qi[i], self.pu[u])
else:
raise PredictionImpossible('User and item are unkown.')
raise PredictionImpossible('User and item are unknown.')

return est

Expand Down Expand Up @@ -737,6 +737,6 @@ class NMF(AlgoBase):
if known_user and known_item:
est = np.dot(self.qi[i], self.pu[u])
else:
raise PredictionImpossible('User and item are unkown.')
raise PredictionImpossible('User and item are unknown.')

return est
2 changes: 1 addition & 1 deletion surprise/prediction_algorithms/slope_one.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class SlopeOne(AlgoBase):
def estimate(self, u, i):

if not (self.trainset.knows_user(u) and self.trainset.knows_item(i)):
raise PredictionImpossible('User and/or item is unkown.')
raise PredictionImpossible('User and/or item is unknown.')

# Ri: relevant items for i. This is the set of items j rated by u that
# also have common users with i (i.e. at least one user has rated both
Expand Down
4 changes: 2 additions & 2 deletions tests/test_algorithms.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ def test_unknown_user_or_item(toy_data):
algo = klass()
algo.fit(trainset)
algo.predict('user0', 'unknown_item', None)
algo.predict('unkown_user', 'item0', None)
algo.predict('unkown_user', 'unknown_item', None)
algo.predict('unknown_user', 'item0', None)
algo.predict('unknown_user', 'unknown_item', None)

# unrelated, but test the fit().test() one-liner:
trainset, testset = train_test_split(toy_data, test_size=2)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,12 @@ def test_trainset_testset(toy_data_reader):
for i in range(4):
assert trainset.to_inner_uid('user' + str(i)) == i
with pytest.raises(ValueError):
trainset.to_inner_uid('unkown_user')
trainset.to_inner_uid('unknown_user')

for i in range(2):
assert trainset.to_inner_iid('item' + str(i)) == i
with pytest.raises(ValueError):
trainset.to_inner_iid('unkown_item')
trainset.to_inner_iid('unknown_item')

# test inner2raw
assert trainset._inner2raw_id_users is None
Expand Down

0 comments on commit 59e6886

Please sign in to comment.