Disable cache #48
Disable cache #48
Conversation
|
Usage: (setq indium-webkit-cache-disabled t) |
indium-webkit.el
Outdated
| @@ -40,6 +40,7 @@ | |||
| (require 'indium-debugger) | |||
| (require 'indium-workspace) | |||
|
|
|||
| (defvar indium-webkit-cache-disabled nil) | |||
There was a problem hiding this comment.
Could you add a docstring for it?
indium-webkit.el
Outdated
| "Disable network cache for each request. If prefix ARG is used enable it." | ||
| (interactive "p") | ||
| (setq indium-webkit-cache-disabled (= arg 1)) | ||
| (indium-webkit--set-cache-disabled indium-webkit-cache-disabled)) |
There was a problem hiding this comment.
Using a prefix argument feels a bit weird IMO.
What about indium-webkit-enable-cache and indium-webkit-disable-cache instead?
| (indium-webkit--send-request '((method . "Network.enable")) | ||
| (lambda (res) | ||
| (when indium-webkit-cache-disabled | ||
| (indium-webkit--set-cache-disabled t))))) |
There was a problem hiding this comment.
Could you add documentation for the new commands and this behavior?
indium-webkit.el
Outdated
| (setq indium-webkit-cache-disabled (= arg 1)) | ||
| (indium-webkit--set-cache-disabled indium-webkit-cache-disabled)) | ||
| (defun indium-webkit-enable-cache () | ||
| "Enabled network cache for each request. And save it for future sessions." |
There was a problem hiding this comment.
I'm being picky here, but I'd like the second sentence to start on a separate line, and not starting with "And".
Also, what does "future sessions" mean? It's not persistent if the user restarts Emacs for instance.
sphinx-doc/network.rst
Outdated
| M-x indium-webkit-disable-cache | ||
| M-x indium-webkit-enable-cache | ||
|
|
||
| Both commands save your choice which will be applied on next indium launch for a current session. |
There was a problem hiding this comment.
Both commands save your choice which will be used for future Indium connections for the current Emacs session?
|
This PR seems to be on top of #46, so I'll wait to it to be merged before merging this one. |
indium-webkit.el
Outdated
| @@ -40,6 +40,8 @@ | |||
| (require 'indium-debugger) | |||
| (require 'indium-workspace) | |||
|
|
|||
| (defvar indium-webkit-cache-disabled nil | |||
| "Network cache disabled state. If t disable cache when Indium starts.") | |||
sphinx-doc/network.rst
Outdated
| M-x indium-webkit-disable-cache | ||
| M-x indium-webkit-enable-cache | ||
|
|
||
| Both commands save your choice which will be used for future Indium connections for the current Emacs session |
* Add indium-webkit-{enable|disable}-cache (see NicolasPetton#34).
* Add a new documentation page about the network.
Fix #34