First implementation bits (long-running PR) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasT
force-pushed
the
hack
branch
2 times, most recently
from
0fb14bf
to
dc5caa9
Compare
This was referenced Mar 21, 2023
|
Anyone interested to review this, I'd appreciate a review of the |
NicolasT
force-pushed
the
hack
branch
9 times, most recently
from
06e5613
to
a8c6f5c
Compare
For now, this library re-uses the `CQueue` module (and its dependencies) from the `distributed-process` library, since the latter doesn't build with recent versions of some dependencies. The code is imported from revision 7b8cbf59cc7f291a524a5c of the upstream repository. See: https://github.com/haskell-distributed/distributed-process.git See: https://raw.githubusercontent.com/haskell-distributed/distributed-process/7b8cbf59cc7f291a524a5c405d514e48e6544182/src/Control/Distributed/Process/Internal/CQueue.hs See: https://raw.githubusercontent.com/haskell-distributed/distributed-process/7b8cbf59cc7f291a524a5c405d514e48e6544182/src/Control/Distributed/Process/Internal/StrictList.hs See: https://raw.githubusercontent.com/haskell-distributed/distributed-process/7b8cbf59cc7f291a524a5c405d514e48e6544182/src/Control/Distributed/Process/Internal/StrictMVar.hs
Ignore both `ormolu` formatting, as well as `hlint`. See: cf2d0f2
Expose the vendored modules from `distributed-process` as an internal library. See: cf2d0f2
While working on some other code, it appeared there's a bug with `spawnLink`. However, after adding this test-case, it doesn't appear to be the case (so further debugging in the other branch is required). Keeping the test-case around doesn't harm, though.
When a process is both linked to as well as monitoring some other process, we want to make sure any exception is propagated through the link before a `Down` message can be observed by said process after which it could, e.g., exit successfully, in case its monitor thread did not (yet) observe the signal to inject. This can be achieved by ensuring there are no pending signals at the end of the `receiveWithOptions` implementation, before delivering any matched message to the caller. This patch includes a test-case which, before the fix, exposes the issue (though this is a bug in concurrency, so it may succeed once in a while). With the fix in place it should now succeed consistently. Fixes: #25 See: #25
troupe: add thread affinity to SpawnOptions
|
@TristanCacqueray With #21 merged here, any chance you could approve this one so it can go in This doesn't imply the current design/implementation is "right", happy to look into various improvements/changes/... to evolve the code. |
TristanCacqueray
approved these changes
Mar 25, 2023
|
Excellent, thank you, I'll give HEAD a try in a test project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code dropping. Not necessarily the way we want things to be.
CQueue, taken fromdistributed-process, is quite complicated. We may want to make this pure STM.CQueue: rework implementation #11)Rework(CQueues "timeout" support using STM'sregisterDelay.CQueue: useregisterDelay#12)MonadProcesswhich exposes some somewhat-high-level actions. However, these can be reimplemented by makingMonadProcessmore low-level. Basically, we'll want a way to retrieve the currentProcessContext, and some otherMaybe ProcessContextbased on aProcessId(in STM). With those in place (and maybe some others), we can implementsendWithOptions,spawnWithOptionsetc. outside of the class.spawnImplFixes: #25