We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple calls to digest() don't return the same answers.
digest()
>>> import crc >>> r = crc.Register(crc.Crc8.BLUETOOTH) >>> r.init() >>> r.update(b"Hello World!") 138 >>> r.digest() 81 >>> r.digest() 138 >>> r.digest() 81
Expected multiple calls to digest() to return the same value.
Return value flip-flops between two values.
I think it is caused by in-place reverse in digest(), L256-L257
The text was updated successfully, but these errors were encountered:
Hi @IsaacDynamo,
nice find 👍! Root cause also seems to be spot on. Thanks for reporting this ❤️, I'll try to address this and provide a release as soon as possible.
Root cause
best Nico
Sorry, something went wrong.
https://github.com/Nicoretti/crc/releases/tag/6.1.2
Nicoretti
Successfully merging a pull request may close this issue.
Summary
Multiple calls to
digest()
don't return the same answers.Reproducing the Issue
Expected Behaviour
Expected multiple calls to
digest()
to return the same value.Actual Behaviour
Return value flip-flops between two values.
Root Cause (optional)
I think it is caused by in-place reverse in
digest()
, L256-L257The text was updated successfully, but these errors were encountered: