Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical error #1361

Closed
fanfani opened this issue Apr 27, 2021 · 1 comment · Fixed by #1358
Closed

Critical error #1361

fanfani opened this issue Apr 27, 2021 · 1 comment · Fixed by #1358
Labels

Comments

@fanfani
Copy link

fanfani commented Apr 27, 2021

Nicotine+ version: 3.0.5
Operating System/Distribution: Linux Mint 20.1

Describe the bug

after last Nicotine+ upgrade i often get sudden program crashes. Never happened before latest upgrade.

Expected behavior

don't crash :-)

Steps to reproduce the bug

i don't know, it happens apparently random.

Additional context

Screenshots, logs, stacktraces or relevant information.

Traceback:

Type: <class 'RuntimeError'>
Value: deque mutated during iteration
Traceback:   File "/usr/lib/python3/dist-packages/pynicotine/gtkgui/frame.py", line 601, in on_network_event
    self.np.events[i.__class__](i)
  File "/usr/lib/python3/dist-packages/pynicotine/pynicotine.py", line 831, in conn_close
    self.closed_connection(msg.conn, msg.addr)
  File "/usr/lib/python3/dist-packages/pynicotine/pynicotine.py", line 819, in closed_connection
    self.transfers.conn_close(conn, addr, i.username, error)
  File "/usr/lib/python3/dist-packages/pynicotine/transfers.py", line 1358, in conn_close
    for i in self.uploads:

@fanfani fanfani added the bug label Apr 27, 2021
@mathiascode
Copy link
Member

Thanks, this should be fixed in unstable (see #1357). Could you also try the unstable PPA for some time? If everything works well, I'll release Nicotine+ 3.0.6 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants