This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Modified tests to workaround TF #29439 issue and checked the compatibility with TF 1.13.1 and 1.14.0rc0 #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he crf.py and misc_io.py to work with TF 1.13.1 and 1.14.0rc0.
|
It's failing 2 of the early stopping tests. @tomvars any idea? |
csudre
approved these changes
Jun 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the tests as a workaround the TF #29439 issue and modified t…he crf.py and misc_io.py to work with TF 1.13.1 and 1.14.0rc0.
Status
READY
Description
The aim of the branch was to solve the TF #29439 issue which was done by creating our own testing case class which inherits from the TF one and deletes the test_case method (bad oop design, but temporary).
Also, the codebase was tested against TF 1.13.1 and 1.14.0rc0 and the required changes to work were made.
Types of changes
Impacted Areas in Application
Nearly all tests
CRF Layer
misc_io.py