-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next release: v2.1.0 #32
Conversation
niftypet/nipet/prj/mmrrec.py
Outdated
snno = Cnt['NSN1'] | ||
elif Cnt['SPN']==11: | ||
elif Cnt['SPN'] == 11: | ||
snno = Cnt['NSN11'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] reported by reviewdog 🐶
F841 local variable 'snno' is assigned to but never used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah but that means span1 isn't supported? and what about catching errors for other (unsupported) spans?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot if osemone supports span 1 or not. If it does, the info will be in Cnt and sinogram size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah but not sure in the logic in the rest of this function checks for that...
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=========================================
Coverage ? 15.26%
=========================================
Files ? 17
Lines ? 3001
Branches ? 0
=========================================
Hits ? 458
Misses ? 2543
Partials ? 0 Continue to review full report at Codecov.
|
fix memleak
/tag v2.1.0 b1c3799 |
NIPET_CU_THREADS=1024
logging
usageresources
get_norm()
np.bool
deprecationclang-format