Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next release: v2.1.0 #32

Merged
merged 68 commits into from
Sep 30, 2021
Merged

next release: v2.1.0 #32

merged 68 commits into from
Sep 30, 2021

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Jan 6, 2021

  • cmake: allow linking shared libs for external builds
  • cmake: expose NIPET_CU_THREADS=1024
  • cmake: fix multi-arch CUDA support
  • setup: move hardware attenuation maps logic to runtime (fixes setup: remove hw mumap etc config #38)
  • optimisation: use CuVec forward & back projectors (fprj & bprj using CuVec #36)
  • update logging usage
  • update resources
  • update GIF parcellation file recognition
  • fix memory leaks (fix memleak #39)
  • fix device ID detection with NInst
  • fix deprecation warnings
  • fix RTX & reduced rings bugs
  • fix & update get_norm()
  • fix span-1 sinogram numbers in scatter and pipe recon
  • fix generating aligned mu-maps when loading existing ones
  • fix np.bool deprecation
  • fix editable installation
  • docs: update examples/demo
  • format: misc tidy & linting
  • major build & test framework updates
    • automate code formatting & basic bug detection
    • isolate test env
    • separate check & deploy
    • add test runner dependencies
    • update pre-commit hooks
    • cmake: static CUDA lib linking
    • use clang-format

niftypet/nipet/img/mmrimg.py Outdated Show resolved Hide resolved
niftypet/nipet/mmraux.py Outdated Show resolved Hide resolved
niftypet/nipet/mmraux.py Outdated Show resolved Hide resolved
niftypet/nipet/mmraux.py Outdated Show resolved Hide resolved
niftypet/nipet/mmraux.py Outdated Show resolved Hide resolved
niftypet/nipet/sct/mmrsct.py Outdated Show resolved Hide resolved
snno = Cnt['NSN1']
elif Cnt['SPN']==11:
elif Cnt['SPN'] == 11:
snno = Cnt['NSN11']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[flake8] reported by reviewdog 🐶
F841 local variable 'snno' is assigned to but never used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed

Copy link
Member Author

@casperdcl casperdcl Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah but that means span1 isn't supported? and what about catching errors for other (unsupported) spans?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot if osemone supports span 1 or not. If it does, the info will be in Cnt and sinogram size.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but not sure in the logic in the rest of this function checks for that...

niftypet/nipet/prj/mmrprj.py Outdated Show resolved Hide resolved
niftypet/nipet/lm/pviews.py Outdated Show resolved Hide resolved
niftypet/nipet/lm/pviews.py Outdated Show resolved Hide resolved
@casperdcl casperdcl changed the title tests isolation & improvements fix bugs & formatting, add tests isolation & improvements Jan 7, 2021
@casperdcl casperdcl changed the title fix bugs & formatting, add tests isolation & improvements next release: v2.1.0 Jan 10, 2021
niftypet/nipet/mmrnorm.py Outdated Show resolved Hide resolved
niftypet/nipet/mmrnorm.py Outdated Show resolved Hide resolved
niftypet/nipet/mmrnorm.py Outdated Show resolved Hide resolved
niftypet/nipet/mmrnorm.py Outdated Show resolved Hide resolved
niftypet/nipet/mmrnorm.py Outdated Show resolved Hide resolved
niftypet/nipet/mmrnorm.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@4f0121d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   15.26%           
=========================================
  Files             ?       17           
  Lines             ?     3001           
  Branches          ?        0           
=========================================
  Hits              ?      458           
  Misses            ?     2543           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0121d...e7d9cfd. Read the comment docs.

@casperdcl
Copy link
Member Author

/tag v2.1.0 b1c3799

@casperdcl casperdcl linked an issue Oct 25, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup: remove hw mumap etc config
2 participants