Drag the handle by clicking anywhere in the component #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution🎉. I modified the code to be compatible with the lazy and touch events. Already released to version 3.0.41 |
|
@doatech Thanks a lot. When these two combine together (event-handler and prop), it definitely handles all the drag, and touch events update from a UX perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core functionality does not allows users to click anywhere on the slider rail and also start the dragging process, which could be desirable from a UX standpoint.
I added a new prop
dragOnClickand functionality which if set to true, should allow the user to start the dragging process (snaps the closes handle, even in range mode) if the user clicks the rail or the marks in the component.Please feel free to comment on this PR regarding the naming and the added functionality.