Use official buildTransitive NuGet support #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dTransitive feature instead of copying the .targets file into every NuGet package that depends on us
…th below buildTransitive
…rnings (although, it appears that netstandard2.0 folder is required for it to actually function on that TFM).
…ibes how to use a subset of resource data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes from a viral copy of the
ICU4N.targetsfile to putting the file in thebuildTransitivefolder within the NuGet package. The feature can be disabled by excluding the feature from the ICU4N PackageReference.It would be best to allow the end consumer to be able to override this, but for now the best advice is to only exclude resources in the executable application that deploys them as files until we build more automation into the build process to pack custom resources. For all intermediate class libraries, it is best to leave the default settings.