Skip to content

Commit

Permalink
Added the AwaitsFixAttribute to the known failing tests described in a…
Browse files Browse the repository at this point in the history
  • Loading branch information
NightOwl888 committed Nov 21, 2020
1 parent c1a5be1 commit 7e6eb91
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#if FEATURE_BREAKITERATOR
#if FEATURE_BREAKITERATOR
using J2N.Threading;
using Lucene.Net.Analysis.Core;
using Lucene.Net.Analysis.TokenAttributes;
Expand Down Expand Up @@ -355,6 +355,7 @@ private static void AssertAnalyzer(Analyzer analyzer, string text)
/// <summary>
/// blast some random strings through the analyzer </summary>
[Test]
[AwaitsFix(BugUrl = "https://github.com/apache/lucenenet/issues/269")] // LUCENENET TODO: this test occasionally fails
public virtual void TestRandomStrings()
{
CheckRandomData(Random, new ThaiAnalyzer(TEST_VERSION_CURRENT), 1000 * RandomMultiplier);
Expand All @@ -364,6 +365,7 @@ public virtual void TestRandomStrings()
/// blast some random large strings through the analyzer </summary>
///
[Test]
[AwaitsFix(BugUrl = "https://github.com/apache/lucenenet/issues/269")] // LUCENENET TODO: this test occasionally fails
public virtual void TestRandomHugeStrings()
{
Random random = Random;
Expand Down
4 changes: 3 additions & 1 deletion src/Lucene.Net.Tests.Expressions/TestExpressionSorts.cs
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,10 @@ public override void TearDown()
base.TearDown();
}

// LUCENENET TODO: Fails on x86, Release, net45 (but doesn't fail if any of these 3 parameters are changed)
[Test]
#if NETFRAMEWORK
[AwaitsFix(BugUrl = "https://github.com/apache/lucenenet/issues/269")] // LUCENENET TODO: this test fails on x86 on .NET Framework in Release mode only
#endif
public virtual void TestQueries()
{
int n = AtLeast(4);
Expand Down
1 change: 1 addition & 0 deletions src/Lucene.Net.Tests.Replicator/Http/HttpReplicatorTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ private void ReopenReader()


[Test]
[AwaitsFix(BugUrl = "https://github.com/apache/lucenenet/issues/269")] // LUCENENET TODO: this test occasionally fails
public void TestBasic()
{
IReplicator replicator = new HttpReplicator(host, port, ReplicationService.REPLICATION_CONTEXT + "/s1", server.CreateHandler());
Expand Down
5 changes: 4 additions & 1 deletion src/Lucene.Net.Tests.Sandbox/Queries/TestSlowFuzzyQuery.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Lucene.Net.Documents;
using Lucene.Net.Documents;
using Lucene.Net.Index;
using Lucene.Net.Search;
using Lucene.Net.Store;
Expand Down Expand Up @@ -338,6 +338,9 @@ public void TestFuzzinessLong()
* is not implemented correctly, there will be problems!
*/
[Test]
#if NETFRAMEWORK
[AwaitsFix(BugUrl = "https://github.com/apache/lucenenet/issues/269")] // LUCENENET TODO: this test fails on x86 on .NET Framework in Release mode only
#endif
public void TestTieBreaker()
{
Directory directory = NewDirectory();
Expand Down
2 changes: 2 additions & 0 deletions src/Lucene.Net.Tests/Index/TestIndexWriter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1439,6 +1439,7 @@ public override void Run()

[Test]
[Slow]
[AwaitsFix(BugUrl = "https://github.com/apache/lucenenet/issues/269")] // LUCENENET TODO: this test occasionally fails
public virtual void TestThreadInterruptDeadlock()
{
IndexerThreadInterrupt t = new IndexerThreadInterrupt(this);
Expand Down Expand Up @@ -1479,6 +1480,7 @@ public virtual void TestThreadInterruptDeadlock()
/// testThreadInterruptDeadlock but with 2 indexer threads </summary>
[Test]
[Slow]
[AwaitsFix(BugUrl = "https://github.com/apache/lucenenet/issues/269")] // LUCENENET TODO: this test occasionally fails
public virtual void TestTwoThreadsInterruptDeadlock()
{
IndexerThreadInterrupt t1 = new IndexerThreadInterrupt(this);
Expand Down
3 changes: 3 additions & 0 deletions src/Lucene.Net.Tests/Search/TestBooleanQuery.cs
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,9 @@ public virtual void TestDeMorgan()
}

[Test]
#if NETFRAMEWORK
[AwaitsFix(BugUrl = "https://github.com/apache/lucenenet/issues/269")] // LUCENENET TODO: this test fails on x86 on .NET Framework in Release mode only
#endif
public virtual void TestBS2DisjunctionNextVsAdvance()
{
Directory d = NewDirectory();
Expand Down
3 changes: 3 additions & 0 deletions src/Lucene.Net.Tests/Search/TestFuzzyQuery.cs
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,9 @@ public virtual void Test2()
/// is not implemented correctly, there will be problems!
/// </summary>
[Test]
#if NETFRAMEWORK
[AwaitsFix(BugUrl = "https://github.com/apache/lucenenet/issues/269")] // LUCENENET TODO: this test fails on x86 on .NET Framework in Release mode only
#endif
public virtual void TestTieBreaker()
{
Directory directory = NewDirectory();
Expand Down
3 changes: 2 additions & 1 deletion src/Lucene.Net.Tests/Support/Index/TestTaskMergeScheduler.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Lucene.Net.Attributes;
using Lucene.Net.Attributes;
using Lucene.Net.Documents;
using Lucene.Net.Index.Extensions;
using Lucene.Net.Store;
Expand Down Expand Up @@ -79,6 +79,7 @@ public override void Eval(MockDirectoryWrapper dir)
}

[Test]
[AwaitsFix(BugUrl = "https://github.com/apache/lucenenet/issues/269")] // LUCENENET TODO: this test occasionally fails
public void TestSubclassTaskMergeScheduler()
{
MockDirectoryWrapper dir = NewMockDirectory();
Expand Down

0 comments on commit 7e6eb91

Please sign in to comment.