Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atomic transactions for transfers #27

Merged
merged 11 commits into from
Oct 9, 2023
Merged

Add atomic transactions for transfers #27

merged 11 commits into from
Oct 9, 2023

Conversation

daveroga
Copy link
Contributor

@daveroga daveroga commented Oct 5, 2023 •
edited
Loading

What does this implement/fix? Explain your changes.

  • Add atomic transactions for transfers

Does this close any currently open issues?

No

What commands can I run to test the change?

Needed this branch of Nightfall now https://github.com/NightfallRollup/nightfall_3.5/pull/162

  • NF_SERVICES_TO_START=blockchain,client,deployer,optimist,worker,client-txw,client-auxw,client-bpw,opt-txw,opt-baw,opt-bpw CONFIRMATIONS=1 ./bin/start-nightfall -g -d
  • curl -k -X POST -d "url=http://optimist" http://localhost:8081/proposer/register
  • npm run eg:ganache:atomic-transaction

Any other comments?

No

@daveroga daveroga self-assigned this Oct 5, 2023
@daveroga daveroga marked this pull request as ready for review October 9, 2023 12:52
@daveroga daveroga requested a review from imagobea October 9, 2023 12:52
@imagobea imagobea linked an issue Oct 9, 2023 that may be closed by this pull request
Enable atomic transactions in nightfall-sdk #24
Closed
@daveroga daveroga merged commit ba06f4d into master Oct 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imagobea imagobea imagobea approved these changes

Assignees

@daveroga daveroga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable atomic transactions in nightfall-sdk
2 participants
@daveroga @imagobea