min function does not working as expected

[lionel87]

I tired to use the built-in min() function on an array containing negative numbers, but the result was wrong.

{% set a = [-5, 5, 10, -10, 20, -20] %}
{{ min(a) }}

Expexted: -20

Got: -10

This is because you do a.sort() then return a[0] and in JS the sort does this:

const a = [-5, 5, 10, -10, 20, -20];
a.sort();
// a => [-10, -20, -5, 10, 20, 5]

https://github.com/NightlyCommit/twing/blob/master/src/lib/extension/core/functions/min.ts#L10

Better (faster) approach would be:

return Math.min.apply(null, array);

The max function does not affected because you wrote a proper compare function there.

[ericmorand]

Will be fixed in Twing@4.0.2 available later today. Thanks for the report. min and max functions were far from implementing the whole spectrum of TwigPHP equivalent. This is now fixed.