Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow user to choose if Nightscout upload uses noise smoothed or unprocessed data #194

Closed
sulkaharo opened this issue Oct 5, 2017 · 13 comments
Assignees

Comments

@sulkaharo
Copy link
Contributor

My assumption is most people expect xDrip uploads to replicate the same data as displayed in the app. As per the gitter discussion, the uploads currently always use unprocessed data, while xDrip displays data smoothed for noise. I'd love the app to implement support for choosing what gets uploaded, where the default behavior would be for the uploads to match the xDrip display, with an optional override to upload smoothed/unprocessed data. This would be especially useful for households that rely on Nightscout for data display (mixed iOS / Android houses).

@AdrianLxM AdrianLxM self-assigned this Oct 6, 2017
@AdrianLxM
Copy link
Contributor

Would you like to test this, please?
#196

@jamorham
Copy link
Collaborator

jamorham commented Oct 9, 2017

This should now be present in the Oct 8th Nightly. Enable it within the REST-API settings in xDrip.

@sulkaharo
Copy link
Contributor Author

Yay will test today, you guys rule

@jamorham
Copy link
Collaborator

Any joy with testing?

@sulkaharo
Copy link
Contributor Author

Flipped the toggle on, haven’t noticed issues so far. I’ll compare the display on xDrip and Nightscout later today

@sulkaharo
Copy link
Contributor Author

I still think the user assumption is the uploads match the glucose displayed in xDrip and uploading the unfiltered data is a special case, so I’d make the toggle default to enabled. With the recent improvement to upload the noise data, I’m not sure what the use care for the raw uploads is.

@gitanO0
Copy link

gitanO0 commented Oct 10, 2017

Where's this toggle again? I looked in the rest-api upload area of settings and in the "extra settings" area. Not seeing it. I have the 10/8 build.

@jamorham
Copy link
Collaborator

You should find it in Cloud Upload -> Rest API -> Send Display Glucose

If not try upgrading to the Oct 10th Nightly as there were actually 3 nightly versions on Oct 8th.

@jamorham
Copy link
Collaborator

@sulkaharo that preference default can be changed for new installations at a later point. First we much ensure that testing is successful.

@gitanO0
Copy link

gitanO0 commented Oct 10, 2017

Ok, I just upgraded to the 10th and I see the setting now. Thx.

@sulkaharo
Copy link
Contributor Author

The comparing between the data in Nightscout and xDrip display, I can't find any anomalies. The sensor output is currently clean though, might need to change a day or two to get CGM noise (the CGM is 13 days old now, should get some noise soon).

@jamorham
Copy link
Collaborator

How is this looking? Should I mark this as resolved?

@jamorham
Copy link
Collaborator

I will mark this as resolved. Please re-open it if further work is needed.

jamorham added a commit that referenced this issue Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants