Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dex share email ID #1974

Closed

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Jan 31, 2022

New Dex share IDs are email addresses.
This adds email format as one of the accepted options.

I have only compiled this. But, cannot test it because I don't have a Dex share account.

@Navid200
Copy link
Collaborator Author

Navid200 commented Jan 31, 2022

If you are experiencing the problem described in the attached open issue, you can test this PR.

BUT, please note there is no guarantee this will fix the problem.

You cannot install this over your existing xDrip. You will need to uninstall your current xDrip first. But, if you uninstall xDrip, you will lose all your settings and data. Therefore, you should save the database before uninstalling.
https://navid200.github.io/xDrip/docs/Backup-Database.html

Don't uninstall before saving the database. If you have saved the database, uninstall xDrip.
Install: https://drive.google.com/drive/folders/1NwTmU9KLKVjq6prlrdPGyKMbBZsjmOLJ?usp=sharing

After installing the test version, restore the database: https://navid200.github.io/xDrip/docs/Restore-Database.html

To undo, uninstall the test version. Install an official release. Then, restore the database again.

@tolot27
Copy link
Collaborator

tolot27 commented Jan 31, 2022

This does not fix #1882.

@Navid200
Copy link
Collaborator Author

Great.
Thanks

@Navid200 Navid200 closed this Jan 31, 2022
@tolot27
Copy link
Collaborator

tolot27 commented Jan 31, 2022

I've cherry-picked your commit and will create a PR and apk soon.

Unfortunately, it does not fulfill my goals having a unit test. 😒

@Navid200
Copy link
Collaborator Author

I thought you meant it did not fix the problem.
Which one is it then? Does it fix the problem but does not have tests?
Or, does it not fix the problem?

@Navid200 Navid200 reopened this Jan 31, 2022
@Navid200
Copy link
Collaborator Author

@tolot27 There are parents who cannot follow their children.
You can always add tests. Can we get this fixed first please?
Please don't label the PR invalid without explaining clearly why it is invalid.

@Navid200 Navid200 removed the invalid label Jan 31, 2022
@tolot27
Copy link
Collaborator

tolot27 commented Jan 31, 2022

Obviously, your commit just add a hint for the keyboard style to the input text. Please use your favorite search engine to find out more details about the flag. This does not fix the problem at all.

If you cannot test your code, please don't open a PR and claim that it will fix an open issue.

I thought you meant it did not fix the problem.

Your commit is a GUI enhancement, I like. Hence, I've added it to my branch. Since it is your commit, it is labeled with your name. This honors your effort.

As I mentioned above, I'll provide a PR soon.

@Navid200
Copy link
Collaborator Author

If you cannot test your code, please don't open a PR and claim that it will fix an open issue.

That's fair

@Navid200
Copy link
Collaborator Author

If I can help with the progress, please let me know.

@Navid200 Navid200 removed the request for review from jamorham January 31, 2022 18:13
@Navid200 Navid200 deleted the Navid_2022_01_30 branch June 12, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants