Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved the search functionality of the search component #100

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

Rajneesh2223
Copy link
Contributor

PR #33
I have modified the search functionality by changing it to onclick event

Copy link

vercel bot commented Jun 14, 2024

@Rajneesh2223 is attempting to deploy a commit to the Niharika's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Rajneesh2223
Copy link
Contributor Author

@Niharika0104
Copy link
Owner

@Rajneesh2223 hey..instead of performing search functionality on the cards which are there are on the home page,just redirect them to that page.Like when user types sarees and clicks on search take them /sarees page this is already set on the category cards(like when u click on saree card you will be redirected to sarees pages).You also do the same,becoz in e commerce applications like Myntra and Amazon whenever you search for something you will be redirected to a page with the products that you searched for.And remove that clear button on navbar,it's not needed.

@Rajneesh2223
Copy link
Contributor Author

thanks for the review i will work on it .

@Rajneesh2223
Copy link
Contributor Author

TrendTrove.-.Google.Chrome.2024-06-18.16-21-20.1.mp4

@Niharika0104
I have changed the implementation of search bar , please review so that i can make pull request . If any changes required I will do it

@Niharika0104 Niharika0104 merged commit 882d7b3 into Niharika0104:main Jun 18, 2024
0 of 2 checks passed
Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trend-trove ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 11:04am
trend-trove-client-side ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 11:04am

@Niharika0104
Copy link
Owner

image
@Rajneesh2223 I merged the code your video shows something what's been deployed it shows something else.Also,when users types on sarees and clicks on search redirect them sarees page(https://trend-trove-client-side.vercel.app/Sarees) right now you are
only filtering on the home page category cards.Did you push the changes to the pr?

@Rajneesh2223
Copy link
Contributor Author

Rajneesh2223 commented Jun 18, 2024

@Niharika0104
Ma'am i just send you the video I havent made the pull request , that why It is showing this .
Please delete that branch , then I will make new pull request to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants