Wikimania branch #12
Merged
Wikimania branch #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework how review states are handled on clientside using Less Also includes code from wikimedia#8 Bug: T134597
Add history link under page name Bug: T137909
Make diff and history links appear red if page does not exist Bug: T137980
This was referenced Jun 21, 2016
Closed
Closed
Fix link to userpage Bug: T137382
| } ); | ||
| $( '.records' ).on( 'click', '.js-compare-button', function () { | ||
| // pass the dataset of the element as an object to toggleComparePane | ||
| toggleComparePane.call(this, this.dataset); | ||
| }); | ||
| } ); |
There was a problem hiding this comment.
}) is the standard when doing MW development. I didn't find anything in the Manual for coding conventions but you'll find examples in the code. I just rely on Bryan's code to check myself: https://github.com/wikimedia/wikimedia-iegreview/blob/master/public/js/site.js#L65
There was a problem hiding this comment.
It seems Bryan wasn't going after conventions there (to a tee); there's a lot of whitespace missing
MusikAnimal
force-pushed
the
wikimania-branch
branch
2 times, most recently
from
d4d166a
to
be7902a
Compare
| // TODO: Ideally the authentication step should be taken care of by a middleware | ||
| // but I haven't found a way to make it work with AJAX requests so far | ||
| $requireAuth = function () use ( $slim ) { | ||
| if ( !$slim->authManager->isAuthenticated() ) { |
There was a problem hiding this comment.
You should move this function to the middleware array above. Line 143.
There was a problem hiding this comment.
And also just move it to Line 200.
MusikAnimal
force-pushed
the
wikimania-branch
branch
from
be7902a
to
a1404c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of Leon's stuff during Wikimania. Each commit represents a specific task, except "Add ability to undo your reviews" which includes the fix for T138098, see 1062088#diff-0a3a612b6e041fccdbde3eaa6b795886R215
For the purposes of reviewing, ignore all .less files except
index.less. 72 of the 80 files changed in this PR are just the Bootstrap Less files being put into version control. Unfortunately there is no composer package or other graceful way of importing these Less files :/