Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe - dont fail on missing metadata #28

Merged
merged 2 commits into from
Sep 19, 2016
Merged

Conversation

eranroz
Copy link
Contributor

@eranroz eranroz commented Sep 18, 2016

No description provided.

@eranroz
Copy link
Contributor Author

eranroz commented Sep 18, 2016

Note: I changed it in the production because the site was broken.

For some reason editor can't be fetched. For now I did some hack
#0 /data/project/copypatrol/src/Dao/EnwikiDao.php(82): Slim\Slim::handleErrors(8, 'Undefined index...', '/data/project/c...', 82, Array)
#1 /data/project/copypatrol/src/Controllers/CopyPatrol.php(136): Plagiabot\Web\Dao\EnwikiDao->getRevisionsEditors(Array)
#2 [internal function]: Plagiabot\Web\Controllers\CopyPatrol->handleGet()
#3 /data/project/copypatrol/vendor/wikimedia/slimapp/src/Controller.php(124): call_user_func_array(Array, Array)
#4 /data/project/copypatrol/src/App.php(184): Wikimedia\Slimapp\Controller->__invoke()
#5 [internal function]: Plagiabot\Web\App->Plagiabot\Web{closure}()
#6 /data/project/copypatrol/vendor/slim/slim/Slim/Route.php(468): call_user_func_array(Object(Closure), Array)
#7 /data/project/copypatrol/vendor/slim/slim/Slim/Slim.php(1357): Slim\Route->dispatch()
#8 /data/project/copypatrol/vendor/slim/slim/Slim/Middleware/Flash.php(85): Slim\Slim->call()
#9 /data/project/copypatrol/vendor/slim/slim/Slim/Middleware/MethodOverride.php(92): Slim\Middleware\Flash->call()
#10 /data/project/copypatrol/vendor/wikimedia/slimapp/src/HeaderMiddleware.php(64): Slim\Middleware\MethodOverride->call()
#11 /data/project/copypatrol/vendor/wikimedia/slimapp/src/CsrfMiddleware.php(66): Wikimedia\Slimapp\HeaderMiddleware->call()
#12 /data/project/copypatrol/vendor/slim/slim/Slim/Middleware/PrettyExceptions.php(67): Wikimedia\Slimapp\CsrfMiddleware->call()
#13 /data/project/copypatrol/vendor/slim/slim/Slim/Slim.php(1302): Slim\Middleware\PrettyExceptions->call()
#14 /data/project/copypatrol/vendor/wikimedia/slimapp/src/AbstractApp.php(171): Slim\Slim->run()
#15 /data/project/copypatrol/public_html/index.php(45): Wikimedia\Slimapp\AbstractApp->run()
#16 {main}

@MusikAnimal MusikAnimal merged commit ecda678 into wikimedia:master Sep 19, 2016
@MusikAnimal
Copy link
Member

I think we'll need some UI changes to indicate the username/revision has been suppressed, but this will work for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants