This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
fix: Removed duplicate retry logic which was causing retries on 400's… #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and many retries on 500's
rdong333
approved these changes
Aug 12, 2020
mayitbeegh
approved these changes
Aug 13, 2020
melanahammel
approved these changes
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had duplicate retry logic which was causing 5 retries on 400 response codes and 15 retries on 500 response codes to the AWS STS endpoint. Removed the duplicate logic so we no longer retry on 400's and only retry 5 times for 500 responses.