MFA String Matching for more languages #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabakakao
changed the title
|
@bwynsm Can you approve this PR? I think it is a straightforward change to add more language support |
bwynsm
approved these changes
Apr 26, 2022
|
@bwynsm would it be possible to release a new version, that it can be used? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match all? language specific strings for MFA verification
Description
With this pull-request I created a tuple with all? language specific MFA extra verification strings
Related Issue
Fixes #339
Fixes #317
Motivation and Context
People with other language than "English" in Okta-Webfrontend get an error, because the regex match did not get, that mfa is needed
How Has This Been Tested?
I tested it with several languages and it works for me
Types of changes
Checklist: