Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin python-dateutil #346

Merged
merged 1 commit into from Apr 26, 2022
Merged

Unpin python-dateutil #346

merged 1 commit into from Apr 26, 2022

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Apr 1, 2022

Description

Unpins a restrictive upper dependency bound

Related Issue

Fixes #313

Motivation and Context

Since there‘s no explanation why your python-dateutil requirement is pinned, I’m going to assume it’s no longer an issue.

Upper bounds are bad if not absolutely necessary: https://iscinumpy.dev/post/bound-version-constraints/

How Has This Been Tested?

I’m going to rely on your CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • N/A I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • N/A I have added tests to cover my changes.
  • All new and existing tests passed.

@rabbittsoup
Copy link

I would think a dateutil requirement should remain in requirements in some form if gimme-aws-creds uses dateutil somewhere. Just not pinned as restrictively.

@rabbittsoup
Copy link

Interesting, a quick search for dateutil doesn’t seem to show it being used in the code at all. If that’s true, then, yeah, it should be removed.

@bwynsm bwynsm merged commit 9606411 into Nike-Inc:master Apr 26, 2022
@flying-sheep flying-sheep deleted the patch-1 branch April 27, 2022 08:38
@alexlatchford
Copy link

alexlatchford commented Aug 23, 2022

Thanks @flying-sheep for the PR, any chance you could push out a release with this change @bwynsm? We currently have some other dependencies (notably jupyter-client) backpinned because of this change so hoping to clear this up if possible!

@epierce epierce mentioned this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python-dateutil requirement conflict
4 participants