Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 Upgrade due to Python 3.7 EOL on June 26 2023 #10

Merged
merged 10 commits into from
May 18, 2023

Conversation

abdulhuq811
Copy link
Collaborator

No description provided.

@abdulhuq811 abdulhuq811 requested a review from a team as a code owner May 18, 2023 15:52
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 91.83% and project coverage change: +0.08 🎉

Comparison is base (d119034) 89.28% compared to head (5ce2698) 89.36%.

❗ Current head 5ce2698 differs from pull request most recent head ed885bc. Consider uploading reports for the commit ed885bc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   89.28%   89.36%   +0.08%     
==========================================
  Files          70       69       -1     
  Lines        2622     2605      -17     
==========================================
- Hits         2341     2328      -13     
+ Misses        281      277       -4     
Impacted Files Coverage Δ
knockoff/utilities/functools.py 90.00% <ø> (+2.50%) ⬆️
knockoff/utilities/orm/sqlalchemy_conn.py 0.00% <ø> (ø)
knockoff/orm.py 61.70% <40.00%> (+1.28%) ⬆️
knockoff/utilities/orm/sql.py 92.04% <50.00%> (+0.93%) ⬆️
knockoff/cli.py 28.88% <83.33%> (ø)
knockoff/sdk/db.py 89.13% <87.50%> (ø)
knockoff/__init__.py 100.00% <100.00%> (ø)
knockoff/cli_v2.py 91.17% <100.00%> (ø)
knockoff/io.py 72.72% <100.00%> (+0.50%) ⬆️
knockoff/knockoff.py 92.85% <100.00%> (ø)
... and 27 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

gregyu
gregyu previously approved these changes May 18, 2023
@abdulhuq811 abdulhuq811 merged commit ef4a451 into master May 18, 2023
3 checks passed
@abdulhuq811 abdulhuq811 deleted the py310-upgrade branch May 18, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants