errorResponseBodySerializer handles strings properly

[nmyers322]

fixes #107

[codecov-io]

Codecov Report

Merging #108 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
- Coverage     91.19%   91.08%   -0.11%     
+ Complexity     2138     2137       -1     
============================================
  Files           150      150              
  Lines          6179     6182       +3     
  Branches        813      815       +2     
============================================
- Hits           5635     5631       -4     
- Misses          362      369       +7     
  Partials        182      182

Impacted Files	Coverage Δ	Complexity Δ
...ke/riposte/util/ErrorContractSerializerHelper.java	81.25% <100%> (+4.32%)	7 <4> (+1)	⬆️
...ient/asynchttp/netty/StreamingAsyncHttpClient.java	74.41% <0%> (-1.63%)	46% <0%> (-2%)
...r/handler/ProxyRouterEndpointExecutionHandler.java	61.25% <0%> (-0.63%)	27% <0%> (-1%)
.../com/nike/riposte/server/logging/AccessLogger.java	96.29% <0%> (+1.48%)	48% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 954c62a...c5161af. Read the comment docs.

[nmyers322]

I amended my commit. Is there a way to kickoff a new coverage report?

[nicmunroe]

It should happen automatically. Looks like Travis had some connectivity issues grabbing dependencies. I retriggered the build. Hopefully when it finishes successfully it'll update the coverage.

[nicmunroe]

Pull errorResponseBody.bodyToSerialize() into a variable so we're not calling it multiple times. Although it would be unwise to do something expensive in that method, we can't control how people will use it, so better safe than sorry.

[nicmunroe]

And I guess that would need to be up top, before the null checks. Hmm. Maybe:

Object bodyToSerialize = (errorResponseBody == null) ? null : errorResponseBody.bodyToSerialize();

And then the null check would just become if (bodyToSerialize == null) { ..., and we can use bodyToSerialize later if it passes the null check.

[nmyers322]

I have amended the commit once more with the requested changes.

[nicmunroe]

Thank you @nmyers322 !