Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Base Structure and GitHub OAuth Login #97

Merged
merged 6 commits into from
May 29, 2024

Conversation

cskcvarma
Copy link

Description

This pull request sets up the base structure for the project and implements the login functionality using GitHub OAuth. This includes necessary configurations and initial setup to enable user authentication via GitHub.

Motivation and Context

These changes are required to establish the foundational structure of the project and provide a seamless login experience using GitHub OAuth. It addresses the need for secure and straightforward user authentication.

How Has This Been Tested?

The changes have been tested in a local development environment. The following tests were conducted:

Verified GitHub OAuth login flow works as expected.
Checked that users are correctly authenticated and redirected post-login.
Ensured no conflicts or issues with the base structure setup.

* Adding a basic mantine theme file. It will be updated as the code base develops.

Any colors or gaps will not be hardcoded.

They should first be defined in the theme and then should be used in the code.

* updating .gitignore
…ure. (#12)

setting up tests in the future will be easier.
* Working version of routing

* Implemented routing, however tests for the login page needs to figured out.
* clean up

* A simple but beautiful login page

* Github Oauth setup
* Fixed testing setup and have all tests for OAuth.

* Fixed remaining TODOs, added tests.

* Adding a DEVELOPER.md and .env.example
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit d003469 into Nike-Inc:feature-ui May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants