Wei recon demo #68
Merged
Wei recon demo #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… they were originally There is still some rearrangement that may occur, but in general, I believe that these function imports are now in their proper places.
Conflicts: vt_config/NSLS-II/init.py
Function searches tree to find requested data set. This improves functionality of our demos, since the requirement that users and viewers of the demos modify all data import paths is no longer mandated. This function is required for the current implementation of the GridRec.vt demo
|
attn @celiafish |
|
Gabe, this PR includes some functions irrelevant to my recon demo. Only vttools/vtmods/io.py contains FindData. All the others are new functions for FXI. Can you separate them and just include FindData, so we can move on to close PR of recon example. After this, can you create a new PR about new functions for FXI, and create a VisTrails workflow to test them? Thanks. |
|
Yep, my mistake |
|
Finally. |
|
Great. Will work on both tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added assistant function for vistrails demos. The addition provides the ability to search a tree for a specified file name, making demos more straight forward to use, and eliminating the requirement that source data paths be modified or altered in order to use the demos.