ENH: Speckle plotting tools #68
Conversation
|
@ericdill , @tacaswell wanted me to return the artists added in each plotting function ( in my earlier PR #66) |
|
@sameera2004 yes, i am planning on doing that |
|
@ericdill sure thanks |
|
Are we going to add ipython-notebook examples in this repo too? @ericdill these fucntions are fine, much better! Thanks |
|
@sameera2004 can you review these changes? |
| `combine_intensity`+1 | ||
| """ | ||
| num_rois = len(combine_intensity) | ||
| if labels is None: |
There was a problem hiding this comment.
I think we need "The labels for each element of the mean_intensity list" before combining it, Therefore, it shouldn't be optional.
Before combining it is better to check all the mean intensities from the different image sets have same label list(index list)
Otherwise it can combine different roi's?
|
@ericdill what is the status of this? |
|
This should be ready to go. I updated the speckle_plotting notebook in scikit-beam/scikit-beam-examples#29 |
|
@ericdill |
|
@ericdill |
|
I am going to remove the ipython notebook from this PR. I am 👎 on having the same notebook in two places. That seems like a recipe for things getting horribly out of sync, right? |
|
Yes sure |
…rage, roi_pixel_plotter
Features - moved imshow kwargs into pass-through dict of kwargs for imshow call - moved semilogy kwargs into pass-through dict of kwargs semilogy call - returns tuple of (AxesImage, Line2D) - takes in tuple of axes for (im_ax, logy_ax) Conflicts: examples/plotting/speckle/speckle-plotting.ipynb
Conflicts: examples/plotting/speckle/speckle-plotting.ipynb
Conflicts: examples/plotting/speckle/speckle-plotting.ipynb
Conflicts: examples/plotting/speckle/speckle-plotting.ipynb
It now accepts a dataframe and plots that. This matches the API on `skxray.core.roi.mean_intensity_sets`, which returns a dataframe. Relevant skxray commit: 34441f96ea1bc6cb70824338455be948d15d66aa Conflicts: examples/plotting/speckle/speckle-plotting.ipynb
Conflicts: examples/plotting/speckle/speckle-plotting.ipynb
Conflicts: examples/plotting/speckle/speckle-plotting.ipynb
|
Ok, rebased with edits to get rid of the notebook from this PR |
|
@ericdill speckle_plotting_tools looks good, can you fix this Travis fail? |
|
Yes I could, but it is failing because there is no .travis file. I will create one in a separate PR |
|
travis is failing because it has no idea what to do, not because there is a specific error |
|
Apparently github has freaked out. All of these commits are already in master... |
ENH: Speckle plotting tools
supersedes #66