Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password strength & validation update, also allowing users to use special characters in passwords #32

Merged
merged 19 commits into from
Jun 3, 2021

Conversation

ricknjacky
Copy link

@ricknjacky ricknjacky commented Jun 1, 2021

issue reference:- #22

Tasks done:-

  • Updated the regex to allow special characters {even the non-native English ones}

  • Used zxcbn for password strength estimation.

  • Enhanced the UI for:-
    -1. strength estimation features of zxcvbn accordingly.
    -2. added a new feature for confirming the password entered.

  • Allow users to signup only if both passwords match.

Copy link
Owner

@NikhilM98 NikhilM98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor changes that need to be done to maintain the code quality.

@ricknjacky ricknjacky requested a review from NikhilM98 June 2, 2021 14:30
@ricknjacky ricknjacky requested a review from NikhilM98 June 2, 2021 16:10
@ricknjacky ricknjacky requested a review from NikhilM98 June 2, 2021 16:44
Copy link
Owner

@NikhilM98 NikhilM98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricknjacky ricknjacky requested a review from NikhilM98 June 2, 2021 17:21
@NikhilM98 NikhilM98 merged commit 9e333ed into NikhilM98:dev Jun 3, 2021
@ricknjacky ricknjacky deleted the password branch June 4, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants