Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples dependencies #56

Merged
merged 6 commits into from Apr 24, 2024

Conversation

bdovaz
Copy link
Contributor

@bdovaz bdovaz commented Jan 31, 2024

There are many of them that had severe vulnerabilities.

Small formatting problems or problems with certain analyzers have also been fixed.

There are many of them that had severe vulnerabilities.

Small formatting problems or problems with certain analyzers have also been fixed.
@bdovaz
Copy link
Contributor Author

bdovaz commented Feb 27, 2024

@NikiforovAll please merge, thanks!

@NikiforovAll
Copy link
Owner

Thank you for the contribution, I will take a look.

@NikiforovAll
Copy link
Owner

Could you please specify what kind of analyzers did you use to make the changes?

@bdovaz
Copy link
Contributor Author

bdovaz commented Feb 29, 2024

Dependency track and Visual Studio IDE (reports vulnerable packages)

@bdovaz
Copy link
Contributor Author

bdovaz commented Mar 12, 2024

@NikiforovAll can you merge and release a new version please? Thanks!

@NikiforovAll
Copy link
Owner

@bdovaz Sorry for the delayed response, I plan to work on 2.0.0 and include your code in release. Also, there are other changes with HTTP client management that I want to change so it might take some time.

@bdovaz
Copy link
Contributor Author

bdovaz commented Mar 26, 2024

Okay, if you need help to solve it faster, let me know.

@PaulARoy
Copy link

Hi @NikiforovAll, would it be possible to integrate this in a patch or alpha version before your 2.0.0?

This is preventing us from upgrading other frameworks and has severe vulnerabilities, if 2.0.0 take some time (no pressure for this!) it would be best to address this early — even if it's just an alpha version with no support.

@bdovaz
Copy link
Contributor Author

bdovaz commented Apr 17, 2024

Same problem here...

@NikiforovAll
Copy link
Owner

NikiforovAll commented Apr 23, 2024

OK, will do that. I plan to do it from scratch based on a contribution from @bdovaz , but essentially it will be a separate PR linked to this one. Also, I would like to update samples dependencies separately

cc: @bdovaz, @PaulARoy

@NikiforovAll
Copy link
Owner

Ref: #61

@NikiforovAll
Copy link
Owner

Added 1.7.0 version, could you please take a look? it would be great if you update dependencies for sample projects in a separate PR

@bdovaz bdovaz changed the title Update dependencies Update samples dependencies Apr 23, 2024
@bdovaz
Copy link
Contributor Author

bdovaz commented Apr 23, 2024

@NikiforovAll I have converted this PR into a PR that only updates dependencies of the examples so it is ready for your review.

As you can see I have unified in the *.props files the same as src to make it easier to manage.

@NikiforovAll
Copy link
Owner

LGTM, thank you for the contribution, @bdovaz

@NikiforovAll
Copy link
Owner

@bdovaz could you please take a look at the build? it fails because of changes in package management

@bdovaz
Copy link
Contributor Author

bdovaz commented Apr 23, 2024

@NikiforovAll I think I have already solved it, the MinimalApiDependsOnNuGetSource project is a bit special because it references NuGet's own published packages, in the end I have disabled ManagePackageVersionsCentrally in that particular case.

@NikiforovAll NikiforovAll merged commit c7e8fca into NikiforovAll:main Apr 24, 2024
8 checks passed
@bdovaz bdovaz deleted the update-dependencies branch April 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants