WIP rate-limiting as middleware per user #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
NikitosnikN
force-pushed
the
feature/test-ai-code-review
branch
from
83f9fb4
to
87147d8
Compare
| @@ -14,9 +14,9 @@ jobs: | |||
| uses: actions/checkout@v3 | |||
|
|
|||
| - name: AI Code Reviewer | |||
| uses: your-username/ai-code-reviewer@main | |||
| uses: freeedcom/ai-codereviewer@v2.7.0 | |||
There was a problem hiding this comment.
Consider using a more descriptive name for your repository. The name ai-codereviewer could be more specific to reflect the functionality of the repository.
| OPENAI_API_MODEL: "gpt-4" |
There was a problem hiding this comment.
The model gpt-4 does not exist. Please use a valid model name.
| func RateLimit(requestsPerSecond int) telebot.MiddlewareFunc { | ||
| return func(next telebot.HandlerFunc) telebot.HandlerFunc { | ||
| return func(c telebot.Context) error { | ||
| u := c.Get(string(user.UserInfoContextKey)).(*user.User) |
There was a problem hiding this comment.
There is a potential for a panic here if the type assertion .(*user.User) fails. It would be safer to use the comma ok idiom to check if the type assertion was successful.
| return func(c telebot.Context) error { | ||
| u := c.Get(string(user.UserInfoContextKey)).(*user.User) | ||
|
|
||
| if u == nil { |
There was a problem hiding this comment.
This check for u == nil is redundant as it will never be nil if the type assertion at line 12 fails. It would be better to remove this check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.