This repository has been archived by the owner on Nov 9, 2018. It is now read-only.
structure rewrite #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make every instance use a minecraft folder
NikkyAI
force-pushed
the
feature/structure-rewrite
branch
from
afde899
to
2ca3e8a
Compare
Open
NikkyAI
added a commit
that referenced
this pull request
May 9, 2017
NikkyAI
added a commit
that referenced
this pull request
May 9, 2017
NikkyAI
added a commit
that referenced
this pull request
May 9, 2017
copygirl
reviewed
May 9, 2017
| var argType = Argument("type", | ||
| "The type of instance can be 'Vanilla', 'Server' or 'MultiMC'"); | ||
| var argName = Argument("name", | ||
| "The name of the pack"); | ||
| var argDirectory = Argument("[directory]", |
There was a problem hiding this comment.
Should the directory argument be removed (and we'll just use the name instead)?
There was a problem hiding this comment.
well that would remove some complications
copygirl
reviewed
May 9, 2017
| var argDirectory = Argument("[directory]", | ||
| "The directory to initialize the pack in. Created if necessary."); | ||
|
|
||
| var optName = Option("-n | --name", | ||
| "Sets the pack name", CommandOptionType.SingleValue); | ||
| var optDescription = Option("-d | --description", |
There was a problem hiding this comment.
I.. guess the description and authors should be removed. Whoever uses init command will edit the config file manually anyway.
copygirl
reviewed
May 9, 2017
| @@ -14,6 +14,10 @@ public interface IInstanceHandler | |||
| /// the specified simplified (safe) instance / folder name. </summary> | |||
| string GetInstancePath(string instanceName); | |||
|
|
|||
| /// <summary> Gets the full path of an instance for this type with | |||
| /// the specified simplified (safe) instance / folder name. </summary> | |||
| string GetInstancePath(string instanceName, string basedir); | |||
There was a problem hiding this comment.
Is the old one still used?
There was a problem hiding this comment.
well all ues of the old one could be changed by passing in the current working directory
|
ping #28 for changes in cli arguments and options |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make every instance use a minecraft folder
closes #27