Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What are 'Methods' in header level by type? #121

Closed
jsbroks opened this issue Jun 7, 2020 · 1 comment · Fixed by #123
Closed

What are 'Methods' in header level by type? #121

jsbroks opened this issue Jun 7, 2020 · 1 comment · Fixed by #123
Assignees
@NiklasRosenstein
Labels
kind/bug

Comments

@jsbroks
Copy link

jsbroks commented Jun 7, 2020

I would assume they are class methods, but the class methods seem to follow the Function header type.
@jsbroks jsbroks changed the title What are methods in header level by type? What are 'Methods' in header level by type? Jun 7, 2020
NiklasRosenstein added a commit that referenced this issue Jun 11, 2020
@NiklasRosenstein
fix #121
6ce8bb5
@NiklasRosenstein NiklasRosenstein linked a pull request Jun 11, 2020 that will close this issue
fix #121 #123
Merged
@NiklasRosenstein
Copy link
Owner

Hey @jsbroks , a "Method" in the MarkdownRenderer.header_level_by_type config is indeed supposed to be for functions inside a class. FIxed in #123

NiklasRosenstein added a commit that referenced this issue Jun 11, 2020
@NiklasRosenstein
fix #121 (#123)
1f25e8d
@NiklasRosenstein NiklasRosenstein self-assigned this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiklasRosenstein NiklasRosenstein

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #121 NiklasRosenstein/pydoc-markdown
2 participants
@NiklasRosenstein @jsbroks