Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docusaurus example to work with beta release #235

Merged
merged 4 commits into from Dec 20, 2021
Merged

Fix docusaurus example to work with beta release #235

merged 4 commits into from Dec 20, 2021

Conversation

chris-stetter
Copy link
Contributor

Since some beta version new files and folders with a prefix underscore will be excluded by docusarus (facebook/docusaurus#6044). The example generates underscore files from the corresponding Python files though. I have updated doscusaurus and the documentation.

@NiklasRosenstein NiklasRosenstein linked an issue Dec 19, 2021 that may be closed by this pull request
@@ -0,0 +1,5 @@
changes:
- type: fix|docs
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be just fix or docs 🙂

Suggested change
- type: fix|docs
- type: docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed now. Happy to contribute!

@NiklasRosenstein
Copy link
Owner

Thanks @chrisstetter , happy to merge after the little fix I requested. 👍

@NiklasRosenstein NiklasRosenstein merged commit c864c68 into NiklasRosenstein:develop Dec 20, 2021
@lucacorbucci
Copy link

Hi @chrisstetter I am trying to run the example with docusaurus but I am having some problems.
Do you know if the latest version of docusaurus has broken anything?

@chris-stetter
Copy link
Contributor Author

I have not tried the latest version yet, so unfortunately I do not know. It is on my agenda but will take some time to be honest.

@lucacorbucci
Copy link

lucacorbucci commented Aug 7, 2022

Thank you for your reply @chrisstetter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docusaurus example: update dependencies/configs?
3 participants