Fix escape_except_blockquotes for greater than 9 block quotes in 1 string #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring
When there are more than 9 block quotes in a string `escape_except_blockquotes` will fail do to the fact that the `BLOCKQUOTE_TOKEN_{i}` replacement will incorrectly match for both `BLOCKQUOTE_TOKEN_1` and `BLOCKQUOTE_TOKEN_10`
This just extends it to `BLOCKQUOTE_TOKEN_{i}_END` so this accidental match doesn't happen.
3 tasks
skip-checks: true
|
Thanks @jackgerrits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are more than 9 block quotes in a string
escape_except_blockquoteswill fail do to the fact that theBLOCKQUOTE_TOKEN_{i}replacement will incorrectly match for bothBLOCKQUOTE_TOKEN_1andBLOCKQUOTE_TOKEN_10This just extends it to
BLOCKQUOTE_TOKEN_{i}_ENDso this accidental match doesn't happen.