Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Bump black to >=23.1.0 #96

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mcintel
Copy link

@mcintel mcintel commented May 10, 2024

Along with this, also needed to bump pydoc-markdown. And for good measure, added docs/_site to .gitignore so slap run docs:build won't show a bunch of new files to add.

@mcintel
Copy link
Author

mcintel commented May 10, 2024

@NiklasRosenstein I didn't totally understand how to add the .changelog/_unreleased.log. If you can give me a tip, I'll be more than happy to add it.

@NiklasRosenstein
Copy link
Owner

Thanks for the contribution @mcintel! You can mimic the same format after generating a fresh uuid for the id field, or install slap-cli with Pip(x) and use slap changelog add -t improvement -d 'Bump black to `>=23.1.0`'

@mcintel
Copy link
Author

mcintel commented May 10, 2024

@NiklasRosenstein Ah, thanks for the info. I see that the verify failed. I'll try to repro and fix.

Thanks for this tool! It's super rad! 😁

Along with this, also needed to bump pydoc-markdown. And for good
measure, added docs/_site to .gitignore so `slap run docs:build` won't
show a bunch of new files to add.
@mcintel mcintel changed the title improvement: Move black dependency up improvement: Bump black to >=23.1.0 May 10, 2024
My version of mypy required this, but the GitHub actions is flagging it
as unused.
@NiklasRosenstein NiklasRosenstein linked an issue May 19, 2024 that may be closed by this pull request
@NiklasRosenstein
Copy link
Owner

Glad you like it ❤️

Black needs to be pinned to a major version as the next major version will most likely have breaking formatting changes; as demonstrated by the Python 3.7 tests (which get a 23.x version and all the other tests get the latest 24.x version).

One workaround would be to run Black for linting in this project separately from the runtime dependency; but I would say we can just drop the 3.7 support all together since that Python version is no longer supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update black dependency
2 participants