refactor: remove annual log map #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the map was only used to map dates to a bool, so it's just a plain set. and with the move to c++23, we have acces to std::chrono::month_day. std::set<std::chrono::month_day> does the job just as good if not better but with less code to maintain. Besides that, the 'date map' variables and members are renamed to just 'dates' as they are not maping a date to anything, just containing a list of dates.
NikolaDucak
force-pushed
the
refactor/remove-annual-log-map
branch
from
a4cb10a
to
12244a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the map was only used to map dates to a bool, so it's just a plain set. and with the move to c++23, we have acces to std::chrono::month_day.
std::set<std::chrono::month_day>does the job just as good if not better but with less code to maintain.Besides that, the 'date map' variables and members are renamed to just 'dates' as they are not maping a date to anything, just containing a list of dates.