Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bevy dependencies updated to master #17

Closed
wants to merge 1 commit into from
Closed

Conversation

Vrixyz
Copy link

@Vrixyz Vrixyz commented Nov 29, 2020

I updated bevy dependency to target master, because I wanted to test a wasm build.

I'm not yet to a wasm build, but examples run fine.

  • It might make sense to have a separate branch to prepare for future bevy versions ?

@Vrixyz Vrixyz mentioned this pull request Nov 29, 2020
@Weasy666
Copy link
Contributor

Weasy666 commented Dec 9, 2020

I am also in favor of this approach, as Bevy currently changes rapidly. So if one wants to experiment with the new Bevy features, they have to fork bevy_lyon and need to change the dependency.

@Nilirad
Copy link
Owner

Nilirad commented Jan 1, 2021

I'm not sure about that feature. This crate used to track the master branch, but since the scope of this project is quite small, and bevy updates come quite often, I think that tracking only the releases can reduce the amount of effort to update the crate.

The best of the two worlds in my opinion could be to track bevy's master branch on a separate branch and keeping this master branch "clean". I see what can I do.

@Nilirad Nilirad closed this Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants