Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.65c] /dank/null crash after upgrading, downgrading and then upgrading #1262

Closed
stefancdr opened this issue Jul 3, 2019 · 8 comments
Closed
Labels
Mod Issue Status: Reported This mod issue has been reported to the mod's issue tracker or is already a known issue there

Comments

@stefancdr
Copy link

stefancdr commented Jul 3, 2019

Modpack version
1.65c

Can the issue be reproduced?
Yes (in SMP), no (in creative SP)

Logs
https://paste.dimdev.org/mihixamege.mccrash

Issue
After upgrading to 1.65b and moving the /dank/null from inventory to quickbar, the game immediately crashes. Also, the texture of the /dank/null (emerald one, in this case) is broken (pink/black).

This appears to be fixed in an (unreleased) 1.74 version of /dank/null, but as I said, that's an unreleased version :-).

Cannot reproduce in SP when creating a new (empty) emerald /dank/null, so it's probably a problem with some form of item in the /dank/null.

@Frikkle
Copy link

Frikkle commented Jul 3, 2019

This issue has already been reported at the mod's issue tracker; see p455w0rds-MC-Mods/DankNull#181

@Frikkle
Copy link

Frikkle commented Jul 3, 2019

Side-effects from this issue are that the affected player cannot log in anymore. You would need to edit the /dank/null out of the player's inventory manually.

The bug doesn't manifest itself for all players; on the same server my (also Emerald tier) Dank Null worked fine after the upgrade. It did however have rendering issues.

@Frikkle Frikkle added Status: Reported This mod issue has been reported to the mod's issue tracker or is already a known issue there Mod Issue Priority: Critical labels Jul 3, 2019
@NielsPilgaard
Copy link
Collaborator

Dammit, I guess 1.65c will be the release then :P

@stefancdr
Copy link
Author

stefancdr commented Jul 7, 2019

Not to necro this, but even in 1.65c, switching the 'active' item in the /dank/null (using alt+click) crashes the /dank/null due to an error in ItemUtils. I would deem it likely this is a version mismatch in E2E; did you perchance rollback /dank/null to an earlier version, but not rollback 'password' util? (I can't spell that name properly, sorry :-)).

This commit seems to have changed it from 'areItemStacksEqual' to 'areItemsEqual', hence why a newer/older version of /dank/null might expect the one method rather than the other.

Edit: crash log https://paste.dimdev.org/cofiqojuho.mccrash

@stefancdr stefancdr changed the title [1.65b] /dank/null crash after upgrading [1.65c] /dank/null crash after upgrading, downgrading and then upgrading Jul 7, 2019
@NielsPilgaard
Copy link
Collaborator

God dammit I may have, double checking.

@NielsPilgaard
Copy link
Collaborator

NielsPilgaard commented Jul 7, 2019

and I'm guessing the new Wireless AE mods from Password need version 151 >_<
Edit: Yep! Downgrading those too I guess.

@NielsPilgaard
Copy link
Collaborator

1.65d going up now, sorry about that.

@stefancdr
Copy link
Author

Can confirm 1.65d fixes my issues.

For future reference: to test if this crashes, try switching active block of the /dank/null with alt+click when having it open, this crashed it in 1.65c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod Issue Status: Reported This mod issue has been reported to the mod's issue tracker or is already a known issue there
Projects
None yet
Development

No branches or pull requests

3 participants