Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draconium Armour requires too much RF to craft #1420

Closed
Trasheater opened this issue Nov 16, 2019 · 7 comments
Closed

Draconium Armour requires too much RF to craft #1420

Trasheater opened this issue Nov 16, 2019 · 7 comments
Labels
Bug A modpack specific bug Status: Fixed In Next Release This issue has been fixed in the next (unreleased) version of the pack

Comments

@Trasheater
Copy link

Modpack version
1.71

Issue
Hi, I posted this issue on the discord but it got no response. When I try to craft the draconic set using the crafting core, it says it requires 10 billion RF, which it does say in the Armor.zs file, but even with more than enough power, the progress bar will reset and stop crafting midway through

Videos online show it as requiring around 1.4 billion RF due to some integer overflow? Not sure

Logs
none

@NielsPilgaard
Copy link
Collaborator

This issue was fixed very recently, please try updating.

@Trasheater
Copy link
Author

I have reinstalled both 1.71 and 1.72, they both have armour with RF of 1.4 billion, is this intentional?

@NielsPilgaard
Copy link
Collaborator

No that is not intentionally, but probably just a visual bug. Does it craft?

@pjc21
Copy link
Contributor

pjc21 commented Nov 17, 2019

Hey, not sure but may have spotted the issue. Just installed a fresh copy of 1.72 which installs ExtendedCrafting-1.12.2-1.5.5.jar

The Changes max RF cost and RF/t from int to long was done in latest version ExtendedCrafting-1.12.2-1.5.6.jar

@NielsPilgaard
Copy link
Collaborator

NielsPilgaard commented Nov 17, 2019

Dammit, that's bad news. The new version causes issues with recipes as well, that's why I downgraded. Have you found other recipes that you can't craft? 2x Draconic Block -> 2x Charged Draconic Block for example?

@Trasheater
Copy link
Author

That one works fine for me, i would think that any recipe that needs more than 2^31-1 RF would either not craft or craft with an incorrect RF value, but on 1.72 I was able to craft the armour (using 1.4 billion RF)

@NielsPilgaard
Copy link
Collaborator

Thanks for the help! :D

@NielsPilgaard NielsPilgaard added Status: Fixed In Next Release This issue has been fixed in the next (unreleased) version of the pack Status: Completed and removed Status: Confirmation Needed labels Nov 17, 2019
SSyl pushed a commit to SSyl/Enigmatica2Expert-SSylTweaks that referenced this issue Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A modpack specific bug Status: Fixed In Next Release This issue has been fixed in the next (unreleased) version of the pack
Projects
None yet
Development

No branches or pull requests

3 participants