Tetra Buffs & Scriptification #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves Tetra materials and replacements into scripts where they can be more easily manipulated. This also brings in all base Tetra materials, allowing them to be modified more simply as well. Left some notes for future material improvements in comments. As proof of concept, all materials have been granted a 20% bonus on durability and magic capacity. All seems to be working well. For simpler management in the future, we may want to consider setting up set 'tiers' for each stat. This way we could say, for instance, that Iron is Tier 3 durability and Tier 2 Speed, while Gold is Tier 1 durability and Tier 3 speed, as a rough example. This way we can have a central place to re-balance all tools against each other. I've opted to delete the JSONs in this PR even though they'll likely remain on a player's instance. The JSON injection is over-writing those same files, however, so it makes no difference. I was seeing the changes from the scripts even with them in place. So this is just a bit of cleanup.
|
Awesome work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves Tetra materials and replacements into scripts where they can be more easily manipulated as a first step towards #1692
This also brings in all base Tetra materials, allowing them to be modified more simply as well. Left some notes for future material improvements in comments.
As proof of concept, all materials have been granted a 20% bonus on durability and magic capacity. All seems to be working well.
For simpler management in the future, we may want to consider setting up set 'tiers' for each stat. This way we could say, for instance, that Iron is Tier 3 durability and Tier 2 Speed, while Gold is Tier 1 durability and Tier 3 speed, as a rough example. This way we can have a central place to re-balance all tools against each other by simply tweaking the values for the tiers themselves.
I've opted to delete the JSONs in this PR even though they'll likely remain on a player's instance. The JSON injection is over-writing those same files, however, so it makes no difference. I was seeing the changes from the scripts even with them in place. So this is just a bit of cleanup.