Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.9 broke ABI #69

Closed
mapreri opened this issue Apr 11, 2022 · 2 comments
Closed

0.2.9 broke ABI #69

mapreri opened this issue Apr 11, 2022 · 2 comments

Comments

@mapreri
Copy link

mapreri commented Apr 11, 2022

Hi,

commit 87fb88b broke the ABI, as re-defining a function as const will drop it from the symbols table.

See https://bugs.debian.org/1006812 for a downstream bug showing how a linked program stopped working.

Please either:

  1. revert that commit
  2. add non-const overloaded variant to retain the ABI
  3. bump the SONAME

Thank you for considering.

@NilsBrause
Copy link
Owner

I am sorry, this happened. I will try to be more careful in the future.
The responsible commit has been reverted for now until there is a version 0.3.x.
Please upgrade to version 0.2.10.

@basilgello
Copy link

@NilsBrause There is another bugreport om Kodi forums, this time on Ubuntu with the following symbol:

_ZN7wayland9display_tC1ENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

which demangles to:

wayland::display_t::display_t(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)

It is a constructor and I don't see it in the reverted commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants