Fix ROOT_URL fully #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NilsIrl
pushed a commit
that referenced
this pull request
Jun 25, 2020
Add ROOT_URL to table of content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should completely fix pastly#15.
I noticed how in some places the LINK variables had ROOT_URLs (https://github.com/pastly/bm/blob/master/internal/globals.sh#L83-L84), but a lot did not, so I just searched for all /posts or /p and prepended the ROOT_URL variable to match the way it was already being done.
This is live at https://aadibajpai.com/blog/ if you want to check once.
This also means there's no need to edit it directly in sed anymore.