Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP-484 #23

Closed
wants to merge 3 commits into from
Closed

PEP-484 #23

wants to merge 3 commits into from

Conversation

lunaluxie
Copy link

@lunaluxie lunaluxie commented Feb 3, 2018 •
edited

Implements PEP-484 typeguessing specifications as requested in Issue #22

autoDocstring now generates docstrings like:

def foo(bar: str, foobar: list = []) -> str:
    """[summary]
    
    Args:
        bar (str): [description]
        foobar (list, optional): Defaults to []. [description]
    
    Returns:
        str: [description]
    """

    return True

Kasper Fredenslund added 3 commits February 3, 2018 14:46
Partially implements pep-484
d61781d 
Function type-annotations for args and returns.
pep-484 keyword arguments
1bb4447
Cleanup
9a072f5
lunaluxie
lunaluxie commented Feb 3, 2018
View reviewed changes
src/parse.ts
@@ -71,7 +73,7 @@ export class PythonParser {
let line_num: number = position.line;
let def_indentation: number = this.getIndentation(document.lineAt(line_num - 1));

while (line_num < document.lineCount - 1) {
while (line_num < document.lineCount) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the return not detected at the last line issue mentioned in Issue #3

@stephen-bunn stephen-bunn mentioned this pull request Feb 5, 2018
Closed
@lunaluxie lunaluxie mentioned this pull request Feb 7, 2018
Closed
@lunaluxie
Copy link
Author

Closing as this PR has been made obsolete by #25

@lunaluxie lunaluxie closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lunaluxie