Fix zone initialisation #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… teardrops. I have seen that sometimes this would get erroneously set to other values (depending seemingly on previous user interaction with other zones). With corner smoothing turned on, the teardrop would no longer be properly tangiental to the pad/track.
This could happen in the same way as the corner smoothing issue - whatever value was last set manually on any zone is applied by default to new zones.
|
Thanks for this fix. |
|
Sorry for the delay. Please note that issue #40 is still not fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the default settings for new zones are whatever values were last manually set. This can result in incorrect zone configuration for teardrops.
Steps to reproduce:
This was observed on KiCAD 6.0.0 release.