Basic usage of parsing string fails with isNil is a user defined error

[xmonader]

import parsetoml


let table1 = parsetoml.parseString(""""
[input]
file_name = "test.txt"

[output]
verbose = true
""")

error:

.nimble/pkgs/parsetoml-0.3.2/parsetoml.nim(1284, 8) Error: usage of 'isNil' is a user-defined error

I'm using nim head

[xmonader]

also when compiling with --nilseqs:on

import parsetoml


let table1 = parsetoml.parseString(""""
[input]
file_name = "test.txt"

[output]
verbose = true
""")

gives

testtoml.nim(4)          testtoml
parsetoml.nim(991)       parseString
parsetoml.nim(985)       parseStream
parsetoml.nim(763)       parseKeyValuePair
Error: unhandled exception: (3:12) key names cannot contain spaces [TomlError]
Error: execution of an external program failed: '/home/ahmed/testtoml '

[kaushalmodi]

I think that error is because of using 4 instead of 3 quotes on line 3:

let table1 = parsetoml.parseString(""""

[xmonader]

@kaushalmodi you're correct my bad thanks

[kaushalmodi]

The issue is still not technically closed, right? It would still fail on devel when not using that switch, right?

[PMunch]

Yeah, the error message is strange but it's cause by the four " characters. Should probably be a better error message. And we should update this to work with the new nil behaviour so I'm keeping this open for now.

[iffy]

I'm getting the same error message for this code:

import strutils
import strformat
import parseopt

var
    filename: string
var p = initOptParser()
for kind, key, val in p.getopt():
    case kind
    of cmdArgument:
        filename = key
    of cmdLongOption:
        discard
    of cmdShortOption:
        discard
    of cmdEnd:
        discard
if filename.isNil():
    echo "Error: provide a filename"
    quit(1)

echo "Success"

How should I check if a string is nil?

[PMunch]

You can't any longer, you just check if it is equal to "". Libraries that used nil checking should switch over to using options

EDIT: Of course in that case you should simply check if filename exists on the filesystem.

[PMunch]

This should be fixed in 6ed000e