Fix/notify startdiscovery failure #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow the flutter application to react on discoverServices throwing an exception, because NSD is already running, forward the error through the onStartDiscoveryFailed error callback. Signed-off-by: Julian Scheel <julian@jusst.de>
Add a type enum, which allows the flutter app to differentiate between different backend failures. Signed-off-by: Julian Scheel <julian@jusst.de>
Treat the onDiscoveryStopped callback as error, which is not completely accurate, but saves us from making the stream's onData callback returning more complex data. Signed-off-by: Julian Scheel <julian@jusst.de>
When calling stopDiscovery the NSNetService calls netServiceBrowserDidStopSearch, once the discovery is actually stopped. Forward this to the dart bindings using the onDiscoveryStopped method, as it is done on Android. Signed-off-by: Julian Scheel <julian@jusst.de>
If searchForServices is not able to actually start searching for services the netServiceBrowser(... didNotSearch) callback is called by the NSNetService. Forward this to the dart bindings using the onStartDiscoveryFailed message, as it is done on Android. Signed-off-by: Julian Scheel <julian@jusst.de>
Restart the discovery service on hot-restart of the app, as the initial start will fail on Android, due to the NSD service already being active. Signed-off-by: Julian Scheel <julian@jusst.de>
This was referenced Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the required bits and pieces to detect when
discoverServices()fails, i.e. after a flutter hot-restart where the discovery backend is still running, but the plugin is not properly bound to it anymore.In order to gracefully recover from this a stop->start cycle needs to be done, for which the app actually needs to know when
stopDiscovery()did actualy finish, for which an error code is added.Fixes #3