fix issue #22 for Windows and Android #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
moved compilesdk to 34 as this will support multiple IPs in Android |
Nimrodda
approved these changes
Feb 2, 2024
|
Yes. But that shouldn't break any implementation.
…On Thu, Feb 1, 2024, 11:54 PM Nimrod Dayan ***@***.***> wrote:
***@***.**** approved this pull request.
Looking good. So on iOS and MacOS the hostAddresses will just be empty I
guess?
—
Reply to this email directly, view it on GitHub
<#55 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGPGOTFGRP4BHJ7QSGSAIDYRSLRFAVCNFSM6AAAAABCTUTCU6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJYGU4TINZXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
ok, but I think it would be good to document it. I unfortunately don't have the time to figure out the implementation for iOS and MacOS, but if you happen to have, then that would be great. |
|
btw there are merge conflicts so I can't merge |
It's just the compilesdk. How can I resolve? |
|
How would I go about updating the docs? Editing the readme.md is easy, but how is the API doc generated? Automatically? |
|
Yes readme update and then I was thinking maybe Dart docs on the property itself or something similar where it will be visible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK I urgently needed support for multiple addresses including ipv6.
I was able to make the change for android and windows but I don't have the tools to work on iOS.
the change should be transparent though.
The NsdServiceInfo class now has a field called 'hostAddresses' which is a nullable list of Strings containing the String representation of ipv4 and ivp6 addresses